Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery_table - add customized diff for specific properties and changes on schema #8232

Merged
merged 1 commit into from
Jan 15, 2021
Merged

bigquery_table - add customized diff for specific properties and changes on schema #8232

merged 1 commit into from
Jan 15, 2021

Conversation

modular-magician
Copy link
Collaborator

resolves 1144

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: made incompatible changes to the `google_bigquery_table.schema` field cause the resource to be recreated

Derived from GoogleCloudPlatform/magic-modules#4400

@modular-magician @dasch
bigquery_table - add customized diff for specific properties and chan…
6cc2157 
…ges on schema (hashicorp#4400)

* Add suport for seperate field entity and forceNew on specific schema table changes

Co-authored-by: Daniel Schierbeck <[email protected]>

* resolve linter issues

* go fmt

* fix readability issues and segement examples

* seperate schema from fields commits

* clean up test code and refactor for better readability

* fix tests, don't return error from json unmarshall

Co-authored-by: Daniel Schierbeck <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a8ff070 into hashicorp:master Jan 15, 2021
@ghost ghost added the size/l label Jan 15, 2021
@ghost
Copy link

ghost commented Feb 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 15, 2021
@modular-magician modular-magician deleted the downstream-pr-db576d6b42c1176e59856c078cd4969d424c6ba1 branch November 17, 2024 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform plan permits renaming BigQuery column
1 participant
@modular-magician